feat(style-acq T12): /methodology — ביטויי-מעבר + אנטי-דפוסים editable #85

Merged
chaim merged 1 commits from worktree-style-acquisition-mvp into main 2026-06-06 19:09:15 +00:00
4 changed files with 137 additions and 0 deletions
Showing only changes of commit e4fbda6c1f - Show all commits

View File

@@ -913,6 +913,8 @@ async def _build_style_context(practice_area: str = "") -> str:
("golden_ratios", "יחסי-זהב (אחוזי-סעיפים)"),
("discussion_rules", "כללי-דיון"),
("content_checklists", "צ׳קליסטים"),
("transition_phrases", "ביטויי-מעבר"),
("anti_patterns", "אנטי-דפוסים (להימנע)"),
):
ov = await db.get_methodology_overrides(cat)
if ov:

View File

@@ -6,6 +6,7 @@ import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
import { GoldenRatiosPanel } from "@/components/methodology/golden-ratios-panel";
import { DiscussionRulesPanel } from "@/components/methodology/discussion-rules-panel";
import { ContentChecklistsPanel } from "@/components/methodology/content-checklists-panel";
import { GenericMethodologyPanel } from "@/components/methodology/generic-methodology-panel";
export default function MethodologyPage() {
return (
@@ -25,6 +26,8 @@ export default function MethodologyPage() {
<TabsTrigger value="ratios">יחסי זהב</TabsTrigger>
<TabsTrigger value="rules">כללי דיון</TabsTrigger>
<TabsTrigger value="checklists">צ׳קליסטים</TabsTrigger>
<TabsTrigger value="transitions">ביטויי מעבר</TabsTrigger>
<TabsTrigger value="antipatterns">אנטי-דפוסים</TabsTrigger>
</TabsList>
<TabsContent value="ratios" className="mt-5">
@@ -38,6 +41,20 @@ export default function MethodologyPage() {
<TabsContent value="checklists" className="mt-5">
<ContentChecklistsPanel />
</TabsContent>
<TabsContent value="transitions" className="mt-5">
<GenericMethodologyPanel
category="transition_phrases"
hint="ביטויי-מעבר של דפנה, מקובצים לפי תוצאה. עריכה כאן זורמת לכותב (T15). ערך = רשימת מחרוזות JSON."
/>
</TabsContent>
<TabsContent value="antipatterns" className="mt-5">
<GenericMethodologyPanel
category="anti_patterns"
hint="דפוסים שדפנה נמנעת מהם — נמדדים ע״י מדד מרחק-הסגנון (T7) ומוזרקים לכותב. ערך = {regex, note}."
/>
</TabsContent>
</Tabs>
</CardContent>
</Card>

View File

@@ -0,0 +1,103 @@
"use client";
import { useState } from "react";
import { Loader2, Save, RotateCcw } from "lucide-react";
import { toast } from "sonner";
import { Button } from "@/components/ui/button";
import { Badge } from "@/components/ui/badge";
import { Textarea } from "@/components/ui/textarea";
import {
useMethodology,
useUpdateMethodology,
useResetMethodology,
} from "@/lib/api/methodology";
/**
* Generic key→JSON editor for methodology categories whose value shape is
* arbitrary (T12: transition_phrases, anti_patterns). Each key is editable as
* formatted JSON; Save validates + upserts an override, Reset restores default.
* These edits flow to the writer via the accumulated-learning channel (T15).
*/
function Row({ category, k, value, isOverride }: {
category: string; k: string; value: unknown; isOverride: boolean;
}) {
const [draft, setDraft] = useState(JSON.stringify(value, null, 2));
const [err, setErr] = useState<string | null>(null);
const update = useUpdateMethodology(category);
const reset = useResetMethodology(category);
const dirty = draft !== JSON.stringify(value, null, 2);
const onSave = () => {
let parsed: unknown;
try {
parsed = JSON.parse(draft);
} catch {
setErr("JSON לא תקין");
return;
}
setErr(null);
update.mutate({ key: k, value: parsed }, {
onSuccess: () => toast.success(`${k} נשמר`),
onError: (e) => toast.error(e instanceof Error ? e.message : "שגיאה"),
});
};
const onReset = () => {
reset.mutate(k, {
onSuccess: () => { toast.success(`${k} אופס לברירת-מחדל`); setDraft(""); },
onError: (e) => toast.error(e instanceof Error ? e.message : "שגיאה"),
});
};
return (
<div className="rounded-lg border border-rule bg-surface p-3 space-y-2">
<div className="flex items-center justify-between gap-2">
<span className="font-mono text-sm text-navy">{k}</span>
<Badge variant={isOverride ? "default" : "secondary"} className="text-[0.65rem]">
{isOverride ? "מותאם" : "ברירת-מחדל"}
</Badge>
</div>
<Textarea
value={draft} rows={Math.min(12, draft.split("\n").length + 1)} dir="ltr"
onChange={(e) => setDraft(e.target.value)}
className="font-mono text-[0.78rem] leading-snug"
/>
{err && <p className="text-danger text-[0.72rem]">{err}</p>}
<div className="flex items-center gap-2 justify-end">
{isOverride && (
<Button size="sm" variant="ghost" disabled={reset.isPending}
onClick={onReset} className="text-ink-muted">
<RotateCcw className="w-3.5 h-3.5 me-1" /> איפוס
</Button>
)}
<Button size="sm" disabled={!dirty || update.isPending} onClick={onSave}
className="bg-navy text-parchment hover:bg-navy-soft">
{update.isPending ? <Loader2 className="w-3.5 h-3.5 animate-spin me-1" />
: <Save className="w-3.5 h-3.5 me-1" />}
שמור
</Button>
</div>
</div>
);
}
export function GenericMethodologyPanel({ category, hint }: { category: string; hint?: string }) {
const { data, isPending, error } = useMethodology(category);
if (error) return <p className="text-danger text-sm">שגיאה בטעינה.</p>;
if (isPending) return <Loader2 className="w-5 h-5 animate-spin text-ink-muted" />;
const items = data?.items ?? {};
return (
<div className="space-y-3">
{hint && <p className="text-[0.8rem] text-ink-muted">{hint}</p>}
{Object.entries(items).map(([k, item]) => (
<Row key={k} category={category} k={k} value={item.value} isOverride={item.is_override} />
))}
{Object.keys(items).length === 0 && (
<p className="text-ink-muted text-sm">אין פריטים.</p>
)}
</div>
);
}

View File

@@ -3995,12 +3995,27 @@ from legal_mcp.services.lessons import (
GOLDEN_RATIOS,
DISCUSSION_RULES,
CONTENT_CHECKLISTS,
ANTI_PATTERNS,
TRANSITION_PHRASES,
)
def _transition_phrases_by_bucket() -> dict[str, list[str]]:
"""Group TRANSITION_PHRASES into editable buckets by outcome (None→universal)."""
out: dict[str, list[str]] = {}
for p in TRANSITION_PHRASES:
bucket = p.get("outcome") or "universal"
out.setdefault(bucket, []).append(p["phrase"])
return out
_METHODOLOGY_DEFAULTS: dict[str, dict] = {
"golden_ratios": {k: {s: list(v) for s, v in sec.items()} for k, sec in GOLDEN_RATIOS.items()},
"discussion_rules": dict(DISCUSSION_RULES),
"content_checklists": dict(CONTENT_CHECKLISTS),
# T12 — editable abstract-profile categories the writer (T15) + metric (T7) consume.
"transition_phrases": _transition_phrases_by_bucket(),
"anti_patterns": {ap["name"]: {"regex": ap["regex"], "note": ap["note"]} for ap in ANTI_PATTERNS},
}
_VALID_CATEGORIES = set(_METHODOLOGY_DEFAULTS.keys())