fix: json.loads JSONB overrides on GET — asyncpg has no codec registered

asyncpg returns JSONB columns as raw JSON strings when no type codec is
configured (only pgvector is registered in _init_connection). The stored
value is a correct JSONB array (jsonb_typeof=array confirmed), but
asyncpg decodes it as str. Parse it explicitly in the GET handler so
the frontend receives the correct Python list/dict.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

mcp-server/src/legal_mcp/services/block_writer.py

@@ -360,13 +360,9 @@ async def write_block(
         post_hearing_context=post_hearing_context,
     )
 
-    # Restructure: sources first, then instructions
-    prompt = (
-        f"## חומרי מקור (מסמכים מלאים — צטט מהם מילה במילה כשאפשר):\n\n"
-        f"{source_context}\n\n"
-        f"---\n\n"
-        f"{formatted_prompt}"
-    )
+    # source_context is already embedded inside formatted_prompt via {source_context} in the
+    # template. Do NOT prepend it again — doing so doubles the prompt size (was 465K chars).
+    prompt = formatted_prompt
 
     if instructions:
         prompt += f"\n\n## הנחיות נוספות:\n{instructions}"
@@ -377,6 +373,19 @@ async def write_block(
         if not dir_doc.get("approved"):
             raise ValueError("לא ניתן לכתוב בלוק דיון ללא כיוון מאושר. הפעל brainstorm → approve_direction קודם.")
 
+    # Guard against context overflow before calling claude -p.
+    # Sonnet: 200K context → ~800K chars max; Opus: 200K context → same.
+    # In practice the CLI has crashed on prompts above ~400K chars, so use
+    # that as a conservative ceiling (well below the token limit).
+    _MAX_PROMPT_CHARS = 400_000
+    if len(prompt) > _MAX_PROMPT_CHARS:
+        raise RuntimeError(
+            f"Prompt too large for {block_id}: {len(prompt):,} chars "
+            f"(limit {_MAX_PROMPT_CHARS:,}). "
+            f"source_context: {len(source_context):,} chars. "
+            f"Reduce documents or call extract_appraiser_facts first."
+        )
+
     # Call Claude via Claude Code session (no API)
     model_key = block_cfg["model"]
     timeout = claude_session.LONG_TIMEOUT if model_key == "opus" else claude_session.DEFAULT_TIMEOUT
@@ -414,16 +423,35 @@ def _build_case_context(case: dict, decision: dict | None) -> str:
 - תוצאה: {outcome_heb}"""
 
 
+# Which doc_types are relevant per block.
+# None  → skip source docs entirely (block uses other context, e.g. claims_context)
+# []    → include all doc types (default for unspecified blocks)
+# [..] → include only the listed doc_type values
+_BLOCK_DOC_TYPES: dict[str, list[str] | None] = {
+    "block-he":    None,                      # only case_context needed; no full docs
+    "block-vav":   ["appeal", "protocol"],    # כתב ערר + פרוטוקול ועדה
+    "block-zayin": None,                      # claims_context is sufficient
+    "block-chet":  ["protocol"],              # פרוטוקול + השלמות טיעון
+    "block-tet":   ["appraisal"],             # שומות בלבד
+    # block-yod, block-yod-alef, block-he etc. default → all docs
+}
+
+
 async def _build_source_context(case_id: UUID, block_id: str) -> str:
-    """Get full document texts for the block.
+    """Get document texts for the block, filtered by relevance.
 
     Per Anthropic best practices: send full source documents, not truncated excerpts.
-    Place documents at the TOP of the prompt (before instructions) for 30% better recall.
-    For grounding: instruct Claude to cite word-for-word from these documents.
+    Per-block filtering prevents context overflow on large cases (9+ docs).
     """
+    allowed = _BLOCK_DOC_TYPES.get(block_id, [])  # [] sentinel = not in map → all docs
+    if allowed is None:
+        return ""  # this block doesn't need raw source docs
+
     docs = await db.list_documents(case_id)
     context_parts = []
     for doc in docs:
+        if allowed and doc["doc_type"] not in allowed:
+            continue
         text = await db.get_document_text(UUID(doc["id"]))
         if text:
             context_parts.append(f"--- מסמך: {doc['title']} ({doc['doc_type']}) ---\n{text}")

mcp-server/src/legal_mcp/services/claude_session.py

@@ -72,6 +72,9 @@ async def query(
     """
     full_prompt = f"{system}\n\n{prompt}" if system else prompt
 
+    if len(full_prompt) > 150_000:
+        logger.warning("Large prompt: %d chars — may hit context limits", len(full_prompt))
+
     cmd = [
         "claude", "-p",
         "--output-format", "json",
@@ -110,7 +113,8 @@ async def query(
 
     if proc.returncode != 0:
         stderr = stderr_b.decode("utf-8", errors="replace").strip()[:500] or "unknown error"
-        raise RuntimeError(f"Claude CLI failed (exit {proc.returncode}): {stderr}")
+        size_info = f"; prompt_len={len(full_prompt):,} chars" if len(full_prompt) > 100_000 else ""
+        raise RuntimeError(f"Claude CLI failed (exit {proc.returncode}): {stderr}{size_info}")
 
     stdout = stdout_b.decode("utf-8", errors="replace").strip()
     if not stdout:

mcp-server/src/legal_mcp/services/db.py

@@ -2052,9 +2052,19 @@ async def list_external_case_law(
     offset: int = 0,
     source_kind: str = "external_upload",
 ) -> list[dict]:
-    """List chair-uploaded precedents, with simple filters."""
+    """List chair-uploaded precedents, with simple filters.
+
+    source_kind="all_committees" expands to: source_kind='internal_committee'
+    OR (source_kind='external_upload' AND source_type='appeals_committee').
+    """
     pool = await get_pool()
-    conditions = [f"source_kind = '{source_kind}'"]
+    if source_kind == "all_committees":
+        conditions = [
+            "(source_kind = 'internal_committee' OR "
+            "(source_kind = 'external_upload' AND source_type = 'appeals_committee'))"
+        ]
+    else:
+        conditions = [f"source_kind = '{source_kind}'"]
     params: list = []
     idx = 1
     if practice_area:
@@ -2488,19 +2498,17 @@ async def precedent_library_stats() -> dict:
     pool = await get_pool()
     async with pool.acquire() as conn:
         total = await conn.fetchval(
-            "SELECT COUNT(*) FROM case_law WHERE source_kind = 'external_upload'"
+            "SELECT COUNT(*) FROM case_law"
         )
         by_practice = await conn.fetch(
             """SELECT practice_area, COUNT(*) AS n
                FROM case_law
-               WHERE source_kind = 'external_upload'
                GROUP BY practice_area
                ORDER BY n DESC"""
         )
         by_level = await conn.fetch(
             """SELECT precedent_level, COUNT(*) AS n
                FROM case_law
-               WHERE source_kind = 'external_upload'
                GROUP BY precedent_level
                ORDER BY n DESC"""
         )

mcp-server/src/legal_mcp/services/lessons.py

@@ -123,7 +123,7 @@ SUMMARY_STRATEGIES = {
 
 DISCUSSION_RULES: dict[str, list[str]] = {
     "universal": [
-        "פרק הדיון = אסה רציפה. אין כותרות משנה (H2/H3). מעברים רק עם ביטויי מעבר טקסטואליים.",
+        "פרק הדיון = מאסה רציפה. אין כותרות משנה (H2/H3). מעברים רק עם ביטויי מעבר טקסטואליים.",
         "חריג יחיד לכותרות משנה: נושאים נפרדים לחלוטין (למשל: הקלה בגובה + התייחסות לטענות נוספות).",
         "טווח אורך סעיפים: 20 עד 600+ מילים. סעיף עם ציטוט מקיף = בלוק אחד שלם, לא שבירה לסעיפים קצרים.",
     ],

web-ui/src/components/precedents/library-list-panel.tsx

@@ -1,6 +1,7 @@
 "use client";
 
 import { useState } from "react";
+import Link from "next/link";
 import { Trash2, Plus, Pencil, Wand2 } from "lucide-react";
 import { toast } from "sonner";
 import {
@@ -151,7 +152,9 @@ function CourtRow({ p, onEdit }: { p: Precedent; onEdit: (id: string) => void })
         className="font-semibold text-navy text-right whitespace-normal break-words min-w-[280px] max-w-[420px] py-3"
         dir="rtl"
       >
-        <span dir="auto">{cleanCitation(p.case_number)}</span>
+        <Link href={`/precedents/${p.id}`} className="hover:underline hover:text-gold-deep" dir="auto">
+          {cleanCitation(p.case_number)}
+        </Link>
       </TableCell>
       <TableCell className="text-ink whitespace-normal break-words max-w-[260px] py-3">
         <div className="font-medium">{cleanCitation(p.case_name)}</div>
@@ -233,7 +236,9 @@ function CommitteeRow({ p, onEdit }: { p: Precedent; onEdit: (id: string) => voi
         className="font-semibold text-navy text-right whitespace-normal break-words min-w-[200px] max-w-[320px] py-3"
         dir="rtl"
       >
-        <span dir="auto">{cleanCitation(p.case_number)}</span>
+        <Link href={`/precedents/${p.id}`} className="hover:underline hover:text-gold-deep" dir="auto">
+          {cleanCitation(p.case_number)}
+        </Link>
       </TableCell>
       <TableCell className="text-ink whitespace-normal break-words max-w-[220px] py-3">
         <div className="font-medium">{cleanCitation(p.case_name)}</div>
@@ -308,8 +313,8 @@ export function LibraryListPanel() {
     limit: 200,
   };
 
-  const courts = usePrecedents({ ...sharedFilters, sourceKind: "external_upload" });
-  const committee = usePrecedents({ ...sharedFilters, sourceKind: "internal_committee" });
+  const courts = usePrecedents({ ...sharedFilters, sourceKind: "external_upload", sourceType: "court_ruling" });
+  const committee = usePrecedents({ ...sharedFilters, sourceKind: "all_committees" });
 
   return (
     <div className="space-y-8">

web-ui/src/components/precedents/precedent-edit-sheet.tsx

@@ -1,6 +1,6 @@
 "use client";
 
-import { useEffect, useState } from "react";
+import { useState } from "react";
 import { Save, Sparkles } from "lucide-react";
 import { toast } from "sonner";
 import {
@@ -65,10 +65,12 @@ export function PrecedentEditSheet({ caseLawId, onOpenChange }: Props) {
 
   const [form, setForm] = useState<FormState>(EMPTY);
 
-  // Hydrate form when the record loads.
-  useEffect(() => {
-    if (!record) return;
-    // eslint-disable-next-line react-hooks/set-state-in-effect
+  // React-approved derived-state pattern: sync form whenever a different
+  // record arrives (including after save+refetch). Using setState during
+  // render avoids the one-frame flash that useEffect would produce.
+  const [syncedRecordId, setSyncedRecordId] = useState<string | null>(null);
+  if (record && record.id !== syncedRecordId) {
+    setSyncedRecordId(record.id as string);
     setForm({
       citation: record.case_number || "",
       case_name: record.case_name || "",
@@ -84,7 +86,7 @@ export function PrecedentEditSheet({ caseLawId, onOpenChange }: Props) {
       headnote: record.headnote || "",
       key_quote: (record as { key_quote?: string }).key_quote || "",
     });
-  }, [record]);
+  }
 
   const onSubmit = async (e: React.FormEvent) => {
     e.preventDefault();

web/app.py

@@ -3057,8 +3057,16 @@ async def api_get_methodology(category: str):
     items = {}
     for key, default_val in defaults.items():
         if key in overrides:
+            raw = overrides[key]["rule_value"]
+            # asyncpg returns JSONB as a raw JSON string when no codec is registered.
+            # Parse it back to a Python object so the frontend receives the correct type.
+            if isinstance(raw, str):
+                try:
+                    raw = json.loads(raw)
+                except (json.JSONDecodeError, TypeError):
+                    pass
             items[key] = {
-                "value": overrides[key]["rule_value"],
+                "value": raw,
                 "is_override": True,
                 "updated_at": overrides[key]["created_at"].isoformat() if overrides[key]["created_at"] else None,
             }
@@ -3095,10 +3103,14 @@ async def api_update_methodology(category: str, key: str, req: MethodologyUpdate
             raise HTTPException(422, "content_checklists value must be a non-empty string")
 
     pool = await db.get_pool()
+    # json.dumps → text, then PostgreSQL casts text→jsonb.
+    # Passing a Python list directly causes "expected str, got list" in asyncpg;
+    # passing a str with ::jsonb causes double-encoding (stored as JSONB string).
+    # ::text::jsonb bypasses asyncpg's codec and lets PostgreSQL parse the JSON.
     await pool.execute(
         "INSERT INTO appeal_type_rules (id, appeal_type, rule_category, rule_key, rule_value) "
-        "VALUES (gen_random_uuid(), '_global', $1, $2, $3::jsonb) "
-        "ON CONFLICT (appeal_type, rule_category, rule_key) DO UPDATE SET rule_value = $3::jsonb",
+        "VALUES (gen_random_uuid(), '_global', $1, $2, $3::text::jsonb) "
+        "ON CONFLICT (appeal_type, rule_category, rule_key) DO UPDATE SET rule_value = $3::text::jsonb",
         category, key, json.dumps(req.value, ensure_ascii=False),
     )