Compare commits
8 Commits
8d933386d3
...
fix/604-pa
| Author | SHA1 | Date | |
|---|---|---|---|
| 0a134d0134 | |||
| 602b42ca5e | |||
| 378e5657b5 | |||
| 6721c0a4ed | |||
| 3da37e1519 | |||
| 6294d94bed | |||
| d0669a0878 | |||
| b9906f6047 |
16
package-lock.json
generated
16
package-lock.json
generated
@@ -8,7 +8,7 @@
|
||||
"name": "@marcusgroup/plugin-legal-ai",
|
||||
"version": "0.1.0",
|
||||
"dependencies": {
|
||||
"@paperclipai/plugin-sdk": "^2026.525.0",
|
||||
"@paperclipai/plugin-sdk": "^2026.722.0",
|
||||
"react": "^19.0.0"
|
||||
},
|
||||
"devDependencies": {
|
||||
@@ -625,12 +625,12 @@
|
||||
}
|
||||
},
|
||||
"node_modules/@paperclipai/plugin-sdk": {
|
||||
"version": "2026.525.0",
|
||||
"resolved": "https://registry.npmjs.org/@paperclipai/plugin-sdk/-/plugin-sdk-2026.525.0.tgz",
|
||||
"integrity": "sha512-7ivXbFSwH7cS+/2WNbPwQve5vVtLnqgxX5lmqTKn+i3fOY03d5KHaYF2bbI5zeTkAAwwEJ0Nz3rfBWNPguRRUw==",
|
||||
"version": "2026.722.0",
|
||||
"resolved": "https://registry.npmjs.org/@paperclipai/plugin-sdk/-/plugin-sdk-2026.722.0.tgz",
|
||||
"integrity": "sha512-2rMJCBo8ZAouuMsapdaY4/l+oHmrXKHW/k/HfPOLCxFng7+g04c5JhoFq+/ptGfNcW3kXzs34y7brviDCml06Q==",
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
"@paperclipai/shared": "2026.525.0",
|
||||
"@paperclipai/shared": "2026.722.0",
|
||||
"zod": "^3.24.2"
|
||||
},
|
||||
"bin": {
|
||||
@@ -646,9 +646,9 @@
|
||||
}
|
||||
},
|
||||
"node_modules/@paperclipai/shared": {
|
||||
"version": "2026.525.0",
|
||||
"resolved": "https://registry.npmjs.org/@paperclipai/shared/-/shared-2026.525.0.tgz",
|
||||
"integrity": "sha512-fbVrEx96oxkxXbRBFDLAgW5Z0lRC7Ii+BeCNhKqKRCg9m2IwtP97CGoOeAROdRrvRpP8Neb3vgaaDbDjXT74lQ==",
|
||||
"version": "2026.722.0",
|
||||
"resolved": "https://registry.npmjs.org/@paperclipai/shared/-/shared-2026.722.0.tgz",
|
||||
"integrity": "sha512-JciI6EbtNwHSeoyN5ZkshwqpyfIluyO46JHp8I7pPCvpJ7Uv7MSZEBs3lKXdXLadFEN6qzfwNmf39xjIFC8isA==",
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
"zod": "^3.24.2"
|
||||
|
||||
@@ -17,7 +17,7 @@
|
||||
"biome:fix": "biome check --write src/"
|
||||
},
|
||||
"dependencies": {
|
||||
"@paperclipai/plugin-sdk": "^2026.525.0",
|
||||
"@paperclipai/plugin-sdk": "^2026.722.0",
|
||||
"react": "^19.0.0"
|
||||
},
|
||||
"devDependencies": {
|
||||
|
||||
87
plugin.json
87
plugin.json
@@ -1,87 +0,0 @@
|
||||
{
|
||||
"id": "marcusgroup.legal-ai",
|
||||
"apiVersion": 1,
|
||||
"version": "0.2.0",
|
||||
"displayName": "Ezer Mishpati - Legal AI",
|
||||
"description": "Integration with legal decision drafting system — case management, semantic search, workflow tracking, QA validation, and learning loop",
|
||||
"author": "Marcus Group",
|
||||
"categories": ["integration"],
|
||||
"minimumHostVersion": "2026.325.0",
|
||||
"capabilities": [
|
||||
"events.subscribe",
|
||||
"issues.read",
|
||||
"issues.create",
|
||||
"issues.update",
|
||||
"issue.comments.create",
|
||||
"issue.comments.read",
|
||||
"agents.read",
|
||||
"agents.invoke",
|
||||
"agent.tools.register",
|
||||
"http.outbound",
|
||||
"plugin.state.read",
|
||||
"plugin.state.write",
|
||||
"jobs.schedule",
|
||||
"activity.log.write",
|
||||
"companies.read",
|
||||
"projects.read",
|
||||
"webhooks.receive"
|
||||
],
|
||||
"entrypoints": {
|
||||
"worker": "dist/worker.js"
|
||||
},
|
||||
"instanceConfigSchema": {
|
||||
"type": "object",
|
||||
"properties": {
|
||||
"legalApiBaseUrl": {
|
||||
"type": "string",
|
||||
"default": "http://localhost:8085",
|
||||
"description": "Base URL for the Ezer Mishpati API"
|
||||
}
|
||||
}
|
||||
},
|
||||
"tools": [
|
||||
{ "toolKey": "legal_case_list", "displayName": "רשימת תיקי ערר" },
|
||||
{ "toolKey": "legal_case_get", "displayName": "פרטי תיק ערר" },
|
||||
{ "toolKey": "legal_case_create", "displayName": "יצירת תיק ערר" },
|
||||
{ "toolKey": "legal_case_update", "displayName": "עדכון תיק ערר" },
|
||||
{ "toolKey": "legal_case_status", "displayName": "סטטוס תהליך עבודה" },
|
||||
{ "toolKey": "legal_search", "displayName": "חיפוש תקדימים" },
|
||||
{ "toolKey": "legal_case_template", "displayName": "תבנית החלטה" },
|
||||
{ "toolKey": "legal_processing_status", "displayName": "סטטוס עיבוד כללי" },
|
||||
{ "toolKey": "legal_document_list", "displayName": "רשימת מסמכים בתיק" },
|
||||
{ "toolKey": "legal_set_outcome", "displayName": "הזנת תוצאת ערר" },
|
||||
{ "toolKey": "legal_get_claims", "displayName": "טענות מחולצות" },
|
||||
{ "toolKey": "legal_search_case", "displayName": "חיפוש בתוך תיק" },
|
||||
{ "toolKey": "legal_find_similar", "displayName": "תקדימים דומים" },
|
||||
{ "toolKey": "legal_run_qa", "displayName": "בדיקת איכות" },
|
||||
{ "toolKey": "legal_trigger_learning", "displayName": "לולאת למידה" },
|
||||
{ "toolKey": "legal_style_guide", "displayName": "מדריך סגנון" }
|
||||
],
|
||||
"jobs": [
|
||||
{
|
||||
"jobKey": "sync-case-status",
|
||||
"displayName": "סנכרון סטטוס תיקים",
|
||||
"description": "סנכרון סטטוס בין legal-ai ל-Paperclip כל 15 דקות",
|
||||
"schedule": "*/15 * * * *"
|
||||
},
|
||||
{
|
||||
"jobKey": "stale-case-reminder",
|
||||
"displayName": "תזכורת תיקים תקועים",
|
||||
"description": "מזהה תיקים שלא עודכנו 3+ ימים ומוסיף תגובה ל-issue",
|
||||
"schedule": "0 8 * * *"
|
||||
},
|
||||
{
|
||||
"jobKey": "weekly-feedback-analysis",
|
||||
"displayName": "ניתוח פידבק שבועי",
|
||||
"description": "מסכם פידבק יו\"ר מהשבוע האחרון ומעדכן את decision-lessons.md",
|
||||
"schedule": "0 19 * * 0"
|
||||
}
|
||||
],
|
||||
"webhooks": [
|
||||
{
|
||||
"endpointKey": "case-status",
|
||||
"displayName": "עדכון סטטוס תיק",
|
||||
"description": "מקבל עדכוני סטטוס מ-legal-ai ומפרסם תגובה על ה-issue המקושר"
|
||||
}
|
||||
]
|
||||
}
|
||||
@@ -2,11 +2,23 @@
|
||||
* HTTP client for Ezer Mishpati legal-ai REST API.
|
||||
*/
|
||||
|
||||
/**
|
||||
* Where the client gets its base URL. A plain string still works; a resolver is
|
||||
* used when the URL comes from company-scoped plugin config, which cannot be
|
||||
* read at worker startup (see worker.ts — `ctx.config.get` needs a company).
|
||||
*/
|
||||
export type BaseUrlSource = string | (() => string | Promise<string>);
|
||||
|
||||
export class LegalApi {
|
||||
constructor(private baseUrl: string) {}
|
||||
constructor(private baseUrl: BaseUrlSource) {}
|
||||
|
||||
private async resolveBaseUrl(): Promise<string> {
|
||||
return typeof this.baseUrl === "string" ? this.baseUrl : this.baseUrl();
|
||||
}
|
||||
|
||||
private async request<T>(path: string, init?: RequestInit): Promise<T> {
|
||||
const res = await fetch(`${this.baseUrl}${path}`, {
|
||||
const base = await this.resolveBaseUrl();
|
||||
const res = await fetch(`${base}${path}`, {
|
||||
...init,
|
||||
headers: {
|
||||
"Content-Type": "application/json",
|
||||
@@ -24,6 +36,10 @@ export class LegalApi {
|
||||
return this.request("/api/cases");
|
||||
}
|
||||
|
||||
async getStatusModel(): Promise<StatusModel> {
|
||||
return this.request("/api/status-model");
|
||||
}
|
||||
|
||||
async getCase(caseNumber: string): Promise<CaseDetails> {
|
||||
return this.request(`/api/cases/${encodeURIComponent(caseNumber)}/details`);
|
||||
}
|
||||
@@ -172,6 +188,21 @@ export interface CaseSummary {
|
||||
status: string;
|
||||
}
|
||||
|
||||
export interface StatusModelEntry {
|
||||
key: string;
|
||||
label: string;
|
||||
description: string;
|
||||
phase: string;
|
||||
selectable: boolean;
|
||||
terminal: boolean;
|
||||
on_enter: string | null;
|
||||
}
|
||||
|
||||
export interface StatusModel {
|
||||
statuses: StatusModelEntry[];
|
||||
phases: Array<{ key: string; label: string }>;
|
||||
}
|
||||
|
||||
export interface CaseDetails {
|
||||
id: string;
|
||||
case_number: string;
|
||||
|
||||
@@ -156,6 +156,23 @@ export default {
|
||||
description: "Get overall system processing status",
|
||||
parametersSchema: { type: "object" as const, properties: {} },
|
||||
},
|
||||
{
|
||||
toolKey: "legal_predecessor_context",
|
||||
name: "legal_predecessor_context",
|
||||
displayName: "הקשר מריצות קודמות",
|
||||
description:
|
||||
"Recent conclusions from prior heartbeat runs on this case (the 'summary' each run left). Call this when RESUMING work on a case to see what earlier sessions already did/decided — instead of re-deriving context from scratch.",
|
||||
parametersSchema: {
|
||||
type: "object" as const,
|
||||
properties: {
|
||||
case_number: {
|
||||
type: "string" as const,
|
||||
description: "Case number (e.g. 1043-02-26)",
|
||||
},
|
||||
},
|
||||
required: ["case_number"],
|
||||
},
|
||||
},
|
||||
],
|
||||
jobs: [
|
||||
{
|
||||
|
||||
326
src/sync-target.test.ts
Normal file
326
src/sync-target.test.ts
Normal file
@@ -0,0 +1,326 @@
|
||||
/// <reference types="node" />
|
||||
|
||||
import assert from "node:assert/strict";
|
||||
import { test } from "node:test";
|
||||
// Excluded from tsc (tsconfig.json) — never bundled/emitted, run natively via
|
||||
// `node --test`, which requires the literal `.ts` extension (Node's ESM
|
||||
// resolver does not remap `.js` specifiers to `.ts` files at runtime).
|
||||
import type { StatusModelEntry } from "./legal-api.ts";
|
||||
import {
|
||||
labelFor,
|
||||
pickSyncTargetIssue,
|
||||
resolveIssueStatus,
|
||||
type SyncCandidate,
|
||||
} from "./sync-target.ts";
|
||||
|
||||
/**
|
||||
* הכלל הישן (worker.ts:894 לפני #446): כל issue מקושר שסטטוסו שונה מהיעד —
|
||||
* נכתב, בלי סינון parentId ובלי סינון-סטטוס.
|
||||
*/
|
||||
function legacyTargets(
|
||||
candidates: readonly SyncCandidate[],
|
||||
targetStatus: string,
|
||||
): string[] {
|
||||
return candidates.filter((c) => c.status !== targetStatus).map((c) => c.id);
|
||||
}
|
||||
|
||||
test("רגרסיית 8125-09-24 / CMPA-140: 11 ה-issues הממשיים של התיק, אף sub-task done לא נבחר", () => {
|
||||
// נמדד ב-DB החי של Paperclip (2026-08-24) — כל ה-issues המקושרים לתיק
|
||||
// 8125-09-24. CMPA-140 (זה שנדרס בפועל, done→in_progress) הוא **ילד** של
|
||||
// CMPA-139, לא שורש. CMPA-139 עצמו אינו ברשימה בכוונה: נמדד שאין לו
|
||||
// רשומת legal-case-number ב-plugin_state, ולכן הוא לא מגיע כמועמד כלל —
|
||||
// לילד יש הורה שאינו מקושר.
|
||||
const candidates: SyncCandidate[] = [
|
||||
{ id: "CMPA-116", status: "cancelled", parentId: null, companyId: "c1" },
|
||||
{ id: "CMPA-84", status: "cancelled", parentId: null, companyId: "c1" },
|
||||
{ id: "CMPA-86", status: "cancelled", parentId: null, companyId: "c1" },
|
||||
{ id: "CMPA-140", status: "done", parentId: "CMPA-139", companyId: "c1" }, // זה שנדרס בפועל
|
||||
{
|
||||
id: "CMPA-141",
|
||||
status: "cancelled",
|
||||
parentId: "CMPA-139",
|
||||
companyId: "c1",
|
||||
},
|
||||
{ id: "CMPA-85", status: "done", parentId: "CMPA-84", companyId: "c1" },
|
||||
{ id: "CMPA-146", status: "done", parentId: "CMPA-84", companyId: "c1" },
|
||||
{ id: "CMPA-147", status: "done", parentId: "CMPA-84", companyId: "c1" },
|
||||
{ id: "CMPA-87", status: "done", parentId: "CMPA-86", companyId: "c1" },
|
||||
{ id: "CMPA-88", status: "done", parentId: "CMPA-86", companyId: "c1" },
|
||||
{
|
||||
id: "CMPA-89",
|
||||
status: "cancelled",
|
||||
parentId: "CMPA-86",
|
||||
companyId: "c1",
|
||||
},
|
||||
];
|
||||
|
||||
// סטטוס-התיק היה drafted → in_progress (CASE_STATUS_TO_ISSUE_STATUS ב-worker.ts).
|
||||
const targetStatus = "in_progress";
|
||||
|
||||
// הכלל הישן היה כותב על CMPA-140 — זה הבאג שתועד.
|
||||
assert.ok(legacyTargets(candidates, targetStatus).includes("CMPA-140"));
|
||||
|
||||
const result = pickSyncTargetIssue(candidates);
|
||||
|
||||
// הכלל החדש אינו כותב על דבר.
|
||||
assert.equal(result.target, null);
|
||||
assert.equal(result.reason, "no_writable_root");
|
||||
});
|
||||
|
||||
test("sub-task יחיד ב-done ומקושר: sub-task לעולם לא נבחר", () => {
|
||||
const candidates: SyncCandidate[] = [
|
||||
{ id: "sub-1", status: "done", parentId: "some-root", companyId: "c1" },
|
||||
];
|
||||
|
||||
const result = pickSyncTargetIssue(candidates);
|
||||
|
||||
assert.equal(result.target, null);
|
||||
assert.equal(result.reason, "no_writable_root");
|
||||
});
|
||||
|
||||
test("sub-task יחיד פתוח (in_progress) + שורש cancelled: פתוח אינו מספיק, חייב שורש", () => {
|
||||
const candidates: SyncCandidate[] = [
|
||||
{ id: "root-1", status: "cancelled", parentId: null, companyId: "c1" },
|
||||
{ id: "sub-1", status: "in_progress", parentId: "root-1", companyId: "c1" },
|
||||
];
|
||||
|
||||
const result = pickSyncTargetIssue(candidates);
|
||||
|
||||
assert.equal(result.target, null);
|
||||
assert.equal(result.reason, "no_writable_root");
|
||||
});
|
||||
|
||||
test("שורש יחיד ב-todo: נבחר", () => {
|
||||
const candidates: SyncCandidate[] = [
|
||||
{ id: "root-1", status: "todo", parentId: null, companyId: "c1" },
|
||||
];
|
||||
|
||||
const result = pickSyncTargetIssue(candidates);
|
||||
|
||||
assert.equal(result.target?.id, "root-1");
|
||||
assert.equal(result.reason, "ok");
|
||||
assert.equal(result.writableRoots, 1);
|
||||
});
|
||||
|
||||
test("שורש יחיד ב-in_review: לא נכתב (הגנת auto-block)", () => {
|
||||
const candidates: SyncCandidate[] = [
|
||||
{ id: "root-1", status: "in_review", parentId: null, companyId: "c1" },
|
||||
];
|
||||
|
||||
const result = pickSyncTargetIssue(candidates);
|
||||
|
||||
assert.equal(result.target, null);
|
||||
assert.equal(result.reason, "no_writable_root");
|
||||
});
|
||||
|
||||
test("שורש יחיד ב-blocked: לא נכתב", () => {
|
||||
const candidates: SyncCandidate[] = [
|
||||
{ id: "root-1", status: "blocked", parentId: null, companyId: "c1" },
|
||||
];
|
||||
|
||||
const result = pickSyncTargetIssue(candidates);
|
||||
|
||||
assert.equal(result.target, null);
|
||||
assert.equal(result.reason, "no_writable_root");
|
||||
});
|
||||
|
||||
test("שני שורשים ברי-כתיבה: ambiguous, לא נכתב", () => {
|
||||
const candidates: SyncCandidate[] = [
|
||||
{ id: "root-1", status: "todo", parentId: null, companyId: "c1" },
|
||||
{ id: "root-2", status: "in_progress", parentId: null, companyId: "c1" },
|
||||
];
|
||||
|
||||
const result = pickSyncTargetIssue(candidates);
|
||||
|
||||
assert.equal(result.target, null);
|
||||
assert.equal(result.reason, "ambiguous_writable_roots");
|
||||
assert.equal(result.writableRoots, 2);
|
||||
});
|
||||
|
||||
test("שורש todo + ילד in_progress: השורש נבחר", () => {
|
||||
const candidates: SyncCandidate[] = [
|
||||
{ id: "root-1", status: "todo", parentId: null, companyId: "c1" },
|
||||
{
|
||||
id: "child-1",
|
||||
status: "in_progress",
|
||||
parentId: "root-1",
|
||||
companyId: "c1",
|
||||
},
|
||||
];
|
||||
|
||||
const result = pickSyncTargetIssue(candidates);
|
||||
|
||||
assert.equal(result.target?.id, "root-1");
|
||||
assert.equal(result.reason, "ok");
|
||||
});
|
||||
|
||||
/**
|
||||
* פיקסצ'ר ריאלי של `/api/status-model` (case_status_model.py) — הסדר קובע
|
||||
* מי הוא "todo" (האינדקס הראשון), ו-`terminal: true` קובע מי "done".
|
||||
*/
|
||||
const STATUS_MODEL: StatusModelEntry[] = [
|
||||
{
|
||||
key: "new",
|
||||
label: "חדש",
|
||||
description: "תיק נפתח, טרם הועלו מסמכים",
|
||||
phase: "intake",
|
||||
selectable: true,
|
||||
terminal: false,
|
||||
on_enter: null,
|
||||
},
|
||||
{
|
||||
key: "processing",
|
||||
label: "בעיבוד",
|
||||
description: "מסמכים בעיבוד",
|
||||
phase: "intake",
|
||||
selectable: false,
|
||||
terminal: false,
|
||||
on_enter: null,
|
||||
},
|
||||
{
|
||||
key: "documents_ready",
|
||||
label: "מסמכים מוכנים",
|
||||
description: "העיבוד הושלם",
|
||||
phase: "intake",
|
||||
selectable: true,
|
||||
terminal: false,
|
||||
on_enter: null,
|
||||
},
|
||||
{
|
||||
key: "analyst_verified",
|
||||
label: 'אומת ע"י אנליסט',
|
||||
description: "אנליסט אימת את התוכן",
|
||||
phase: "analysis",
|
||||
selectable: true,
|
||||
terminal: false,
|
||||
on_enter: null,
|
||||
},
|
||||
{
|
||||
key: "research_complete",
|
||||
label: "מחקר הושלם",
|
||||
description: "מחקר תקדימים הושלם",
|
||||
phase: "analysis",
|
||||
selectable: true,
|
||||
terminal: false,
|
||||
on_enter: null,
|
||||
},
|
||||
{
|
||||
key: "outcome_set",
|
||||
label: "תוצאה נקבעה",
|
||||
description: "תוצאה הוזנה",
|
||||
phase: "analysis",
|
||||
selectable: true,
|
||||
terminal: false,
|
||||
on_enter: null,
|
||||
},
|
||||
{
|
||||
key: "direction_approved",
|
||||
label: "כיוון אושר",
|
||||
description: "כיוון הכתיבה אושר",
|
||||
phase: "drafting",
|
||||
selectable: true,
|
||||
terminal: false,
|
||||
on_enter: null,
|
||||
},
|
||||
{
|
||||
key: "qa_review",
|
||||
label: "בדיקת איכות",
|
||||
description: "בבדיקת איכות",
|
||||
phase: "drafting",
|
||||
selectable: true,
|
||||
terminal: false,
|
||||
on_enter: null,
|
||||
},
|
||||
{
|
||||
key: "drafted",
|
||||
label: "טיוטה מוכנה",
|
||||
description: "טיוטה נכתבה",
|
||||
phase: "drafting",
|
||||
selectable: true,
|
||||
terminal: false,
|
||||
on_enter: null,
|
||||
},
|
||||
{
|
||||
key: "exported",
|
||||
label: "יוצא ל-DOCX",
|
||||
description: "יוצא כקובץ DOCX",
|
||||
phase: "review",
|
||||
selectable: true,
|
||||
terminal: false,
|
||||
on_enter: null,
|
||||
},
|
||||
{
|
||||
key: "reviewed",
|
||||
label: 'נבדק ע"י דפנה',
|
||||
description: "דפנה הגיהה",
|
||||
phase: "review",
|
||||
selectable: true,
|
||||
terminal: false,
|
||||
on_enter: null,
|
||||
},
|
||||
{
|
||||
key: "final",
|
||||
label: "סופי",
|
||||
description: "גרסה סופית",
|
||||
phase: "final",
|
||||
selectable: true,
|
||||
terminal: true,
|
||||
on_enter: null,
|
||||
},
|
||||
];
|
||||
|
||||
test("resolveIssueStatus: הסטטוס הראשון ברשימה (new) → todo", () => {
|
||||
assert.equal(resolveIssueStatus(STATUS_MODEL, "new"), "todo");
|
||||
});
|
||||
|
||||
test("resolveIssueStatus: סטטוס terminal (final) → done", () => {
|
||||
assert.equal(resolveIssueStatus(STATUS_MODEL, "final"), "done");
|
||||
});
|
||||
|
||||
test("resolveIssueStatus: analyst_verified (חסר במפה הישנה) → in_progress", () => {
|
||||
assert.equal(
|
||||
resolveIssueStatus(STATUS_MODEL, "analyst_verified"),
|
||||
"in_progress",
|
||||
);
|
||||
});
|
||||
|
||||
test("resolveIssueStatus: research_complete → in_progress", () => {
|
||||
assert.equal(
|
||||
resolveIssueStatus(STATUS_MODEL, "research_complete"),
|
||||
"in_progress",
|
||||
);
|
||||
});
|
||||
|
||||
test("resolveIssueStatus: סטטוס לא-מוכר → null (לא בליעה שקטה)", () => {
|
||||
assert.equal(
|
||||
resolveIssueStatus(STATUS_MODEL, "totally_unknown_status"),
|
||||
null,
|
||||
);
|
||||
});
|
||||
|
||||
test("labelFor: מחזיר את התווית מהפיקסצ'ר, ו-null לסטטוס לא-מוכר", () => {
|
||||
assert.equal(labelFor(STATUS_MODEL, "new"), "חדש");
|
||||
assert.equal(labelFor(STATUS_MODEL, "totally_unknown_status"), null);
|
||||
});
|
||||
|
||||
test("רגרסיה: companyId של המועמד-הנבחר שורד את pickSyncTargetIssue (לא companyId חיצוני קבוע)", () => {
|
||||
const candidates: SyncCandidate[] = [
|
||||
{
|
||||
id: "issue-a",
|
||||
status: "cancelled",
|
||||
parentId: null,
|
||||
companyId: "company-a",
|
||||
},
|
||||
{
|
||||
id: "issue-b",
|
||||
status: "todo",
|
||||
parentId: null,
|
||||
companyId: "company-b",
|
||||
},
|
||||
];
|
||||
|
||||
const result = pickSyncTargetIssue(candidates);
|
||||
|
||||
assert.equal(result.target?.id, "issue-b");
|
||||
assert.equal(result.target?.companyId, "company-b");
|
||||
});
|
||||
112
src/sync-target.ts
Normal file
112
src/sync-target.ts
Normal file
@@ -0,0 +1,112 @@
|
||||
/**
|
||||
* בחירת יעד-הסנכרון של הג'וב `sync-case-status` (issue #446).
|
||||
*
|
||||
* המקור לבאג: הג'וב הישן כתב על **כל** issue מקושר-לתיק, כולל sub-issues
|
||||
* ו-issues בסטטוסים סגורים/בהמתנה-לאדם. זה החזיר CMPA-140 מ-`done` ל-`in_progress`
|
||||
* (8125-09-24) — כי sub-task שהושלם עדיין נמנה כ"מקושר".
|
||||
*
|
||||
* המודול הזה טהור בכוונה — בלי import מה-SDK ובלי side effects — כדי שאפשר
|
||||
* יהיה לייבא אותו ישירות בטסט בלי להריץ את `runWorker(plugin, import.meta.url)`
|
||||
* שקורה בזמן import של worker.ts. ה-import היחיד למטה הוא type-only (`import
|
||||
* type`), כך שהוא לא נדרס בזמן ריצה ולא שובר את הטוהר הזה.
|
||||
*/
|
||||
|
||||
import type { StatusModelEntry } from "./legal-api.ts";
|
||||
|
||||
/** "סגור" — ההגדרה היחידה. מראה של web/paperclip_client.py:561 ב-legal-ai. */
|
||||
export const CLOSED_ISSUE_STATUSES: ReadonlySet<string> = new Set([
|
||||
"done",
|
||||
"cancelled",
|
||||
]);
|
||||
|
||||
/**
|
||||
* מצב בבעלות Paperclip / בהמתנה-לאדם — **לא** הגדרה שנייה של "סגור".
|
||||
* `in_review` הוא מצב-ההמתנה-ליו"ר המכוון: CEO שמשאיר issue ב-`in_progress`
|
||||
* מקבל auto-block מ-Paperclip תוך דקה, ולכן הוא מעביר ל-`in_review`
|
||||
* (legal-ai/docs/paperclip-quirks.md §3). כתיבת-סטטוס אוטומטית עליו גונבת את
|
||||
* ה-issue מתור-הביקורת של היו"ר ומזמינה קרב-סטטוסים.
|
||||
* `blocked` — כתיבה עליו מסתירה חוסם קיים.
|
||||
*/
|
||||
export const NON_WRITABLE_STATUSES: ReadonlySet<string> = new Set([
|
||||
"in_review",
|
||||
"blocked",
|
||||
]);
|
||||
|
||||
export interface SyncCandidate {
|
||||
id: string;
|
||||
status: string;
|
||||
parentId: string | null;
|
||||
companyId: string;
|
||||
}
|
||||
|
||||
export type SyncTargetReason =
|
||||
| "ok"
|
||||
| "no_linked_issues"
|
||||
| "no_writable_root"
|
||||
| "ambiguous_writable_roots";
|
||||
|
||||
export interface SyncTargetResult {
|
||||
target: SyncCandidate | null;
|
||||
reason: SyncTargetReason;
|
||||
/** כמה שורשים ברי-כתיבה נמצאו — לצורך לוג. */
|
||||
writableRoots: number;
|
||||
}
|
||||
|
||||
export function isWritableStatus(status: string): boolean {
|
||||
return (
|
||||
!CLOSED_ISSUE_STATUSES.has(status) && !NON_WRITABLE_STATUSES.has(status)
|
||||
);
|
||||
}
|
||||
|
||||
export function pickSyncTargetIssue(
|
||||
candidates: readonly SyncCandidate[],
|
||||
): SyncTargetResult {
|
||||
if (candidates.length === 0) {
|
||||
return { target: null, reason: "no_linked_issues", writableRoots: 0 };
|
||||
}
|
||||
|
||||
const roots = candidates.filter(
|
||||
(c) => c.parentId === null && isWritableStatus(c.status),
|
||||
);
|
||||
|
||||
if (roots.length === 1) {
|
||||
return { target: roots[0], reason: "ok", writableRoots: 1 };
|
||||
}
|
||||
if (roots.length === 0) {
|
||||
return { target: null, reason: "no_writable_root", writableRoots: 0 };
|
||||
}
|
||||
return {
|
||||
target: null,
|
||||
reason: "ambiguous_writable_roots",
|
||||
writableRoots: roots.length,
|
||||
};
|
||||
}
|
||||
|
||||
/**
|
||||
* Derive the coarse Paperclip issue status for a legal-ai case status, using
|
||||
* only generic fields already returned by legal-ai's `/api/status-model`
|
||||
* (the canonical `case_status_model.py` registry) — never a hardcoded list of
|
||||
* case-status keys. This is what makes a new case status "just work" without
|
||||
* editing this plugin: `terminal: true` → done; the very first status in the
|
||||
* ordered list → todo (nothing has started yet); everything else → in_progress.
|
||||
* Returns `null` when `caseStatus` is not present in `statuses` at all (a
|
||||
* genuinely unknown status — the caller must log this loudly, never swallow
|
||||
* it silently; see legal-ai issue #604).
|
||||
*/
|
||||
export function resolveIssueStatus(
|
||||
statuses: readonly StatusModelEntry[],
|
||||
caseStatus: string,
|
||||
): "todo" | "in_progress" | "done" | null {
|
||||
const index = statuses.findIndex((s) => s.key === caseStatus);
|
||||
if (index === -1) return null;
|
||||
if (statuses[index].terminal) return "done";
|
||||
return index === 0 ? "todo" : "in_progress";
|
||||
}
|
||||
|
||||
/** Hebrew label for a case status from the canonical model, or null if unknown. */
|
||||
export function labelFor(
|
||||
statuses: readonly StatusModelEntry[],
|
||||
caseStatus: string,
|
||||
): string | null {
|
||||
return statuses.find((s) => s.key === caseStatus)?.label ?? null;
|
||||
}
|
||||
207
src/worker.ts
207
src/worker.ts
@@ -4,6 +4,12 @@ import type {
|
||||
} from "@paperclipai/plugin-sdk";
|
||||
import { definePlugin, runWorker } from "@paperclipai/plugin-sdk";
|
||||
import { LegalApi } from "./legal-api.js";
|
||||
import {
|
||||
labelFor,
|
||||
pickSyncTargetIssue,
|
||||
resolveIssueStatus,
|
||||
type SyncCandidate,
|
||||
} from "./sync-target.js";
|
||||
|
||||
// Hoisted so onWebhook can access the context after setup() completes.
|
||||
let pluginCtx: PluginContext | null = null;
|
||||
@@ -16,16 +22,79 @@ const CEO_AGENT_IDS: Record<string, string> = {
|
||||
"cdbfa8bc-3d61-41a4-a2e7-677ec7d34562", // CMPA (היטלי השבחה)
|
||||
};
|
||||
|
||||
const DEFAULT_LEGAL_API_BASE = "http://localhost:8085";
|
||||
|
||||
/**
|
||||
* Resolve `legalApiBaseUrl` from company-scoped plugin config.
|
||||
*
|
||||
* ⚠️ Plugin config became company-scoped in @paperclipai/server 2026.722.0
|
||||
* (migration `0164_plugin_config_company_scope`). A bare `ctx.config.get()` now
|
||||
* throws `company context is required` unless the host can derive the company
|
||||
* from the current invocation — which it CANNOT during `setup()`, because
|
||||
* worker initialisation belongs to no company. Reading config at startup is what
|
||||
* made the whole plugin fail to activate on the 722.0 upgrade.
|
||||
*
|
||||
* So: never call this from setup(); call it from a handler, passing the
|
||||
* companyId that handler was given. Tool handlers get `runCtx.companyId`; data
|
||||
* handlers get `params.companyId`. Scheduled jobs have no company at all, so
|
||||
* they fall back to probing the companies we know about.
|
||||
*/
|
||||
/** Pull the companyId the host passes to `ctx.data` handlers, if present. */
|
||||
function companyIdOf(params: unknown): string | undefined {
|
||||
const id = (params as { companyId?: unknown } | null)?.companyId;
|
||||
return typeof id === "string" && id.trim() ? id : undefined;
|
||||
}
|
||||
|
||||
async function resolveApiBase(
|
||||
ctx: PluginContext,
|
||||
companyId?: string,
|
||||
): Promise<string> {
|
||||
const read = async (id?: string): Promise<string | null> => {
|
||||
try {
|
||||
const cfg = (await ctx.config.get(id)) as {
|
||||
legalApiBaseUrl?: unknown;
|
||||
} | null;
|
||||
const url = cfg?.legalApiBaseUrl;
|
||||
return typeof url === "string" && url.trim() ? url.trim() : null;
|
||||
} catch {
|
||||
return null;
|
||||
}
|
||||
};
|
||||
|
||||
if (companyId) {
|
||||
const scoped = await read(companyId);
|
||||
if (scoped) return scoped;
|
||||
}
|
||||
|
||||
// No companyId passed in — but the host derives one itself when the call
|
||||
// happens inside a host-scoped invocation (e.g. a tool handler). Ask before
|
||||
// falling back to guesswork, so tools honour their own company's config.
|
||||
const derived = await read(undefined);
|
||||
if (derived) return derived;
|
||||
|
||||
// Genuinely no company (scheduled jobs): try each company we know of. All of
|
||||
// them point at the same legal-ai instance in practice, so the first hit wins.
|
||||
for (const knownCompanyId of Object.keys(CEO_AGENT_IDS)) {
|
||||
const url = await read(knownCompanyId);
|
||||
if (url) return url;
|
||||
}
|
||||
|
||||
ctx.logger.warn("legalApiBaseUrl unresolved — using default", {
|
||||
companyId: companyId ?? null,
|
||||
fallback: DEFAULT_LEGAL_API_BASE,
|
||||
});
|
||||
return DEFAULT_LEGAL_API_BASE;
|
||||
}
|
||||
|
||||
const plugin = definePlugin({
|
||||
async setup(ctx) {
|
||||
pluginCtx = ctx; // save for onWebhook
|
||||
const config = (await ctx.config.get()) as {
|
||||
legalApiBaseUrl?: string;
|
||||
} | null;
|
||||
const baseUrl = config?.legalApiBaseUrl || "http://localhost:8085";
|
||||
const api = new LegalApi(baseUrl);
|
||||
|
||||
ctx.logger.info("Legal AI plugin starting", { url: baseUrl });
|
||||
// Lazy: the URL is fetched on the first request, from inside a handler
|
||||
// that has company context — not here. See resolveApiBase() above.
|
||||
const api = new LegalApi(() => resolveApiBase(ctx));
|
||||
|
||||
ctx.logger.info("Legal AI plugin starting");
|
||||
|
||||
// ── Tools ──────────────────────────────────────────────────────
|
||||
|
||||
@@ -778,76 +847,86 @@ const plugin = definePlugin({
|
||||
const cases = await api.listCases();
|
||||
const companies = await ctx.companies.list();
|
||||
if (!companies.length) return;
|
||||
const statusModel = await api.getStatusModel();
|
||||
|
||||
const companyId = companies[0].id;
|
||||
const issues = await ctx.issues.list({ companyId });
|
||||
|
||||
for (const legalCase of cases) {
|
||||
// מעבר אחד על ה-issues של כל חברה: state.get אחד ל-issue (לא לכל
|
||||
// צירוף תיק×issue), וקיבוץ למפה case_number → מועמדים. הקיבוץ נדרש
|
||||
// כדי לבחור "השורש היחיד". סורק את **כל** החברות (לא רק הראשונה) —
|
||||
// legal-ai issue #604.
|
||||
const byCase = new Map<string, SyncCandidate[]>();
|
||||
for (const company of companies) {
|
||||
const issues = await ctx.issues.list({ companyId: company.id });
|
||||
for (const issue of issues) {
|
||||
const linkedCase = await ctx.state.get({
|
||||
scopeKind: "issue",
|
||||
scopeId: issue.id,
|
||||
stateKey: "legal-case-number",
|
||||
});
|
||||
if (typeof linkedCase !== "string" || !linkedCase) continue;
|
||||
const list = byCase.get(linkedCase) ?? [];
|
||||
list.push({
|
||||
id: issue.id,
|
||||
status: issue.status,
|
||||
parentId: issue.parentId,
|
||||
companyId: company.id,
|
||||
});
|
||||
byCase.set(linkedCase, list);
|
||||
}
|
||||
}
|
||||
|
||||
if (linkedCase === legalCase.case_number) {
|
||||
// Map 13 legal-ai statuses to Paperclip issue status
|
||||
const statusMap: Record<string, "todo" | "in_progress" | "done"> =
|
||||
for (const legalCase of cases) {
|
||||
const targetStatus = resolveIssueStatus(
|
||||
statusModel.statuses,
|
||||
legalCase.status,
|
||||
);
|
||||
if (targetStatus === null) {
|
||||
ctx.logger.warn(
|
||||
"sync-case-status: unknown case status — not in /api/status-model (case_status_model.py)",
|
||||
{
|
||||
new: "todo",
|
||||
uploading: "todo",
|
||||
processing: "in_progress",
|
||||
documents_ready: "in_progress",
|
||||
outcome_set: "in_progress",
|
||||
brainstorming: "in_progress",
|
||||
direction_approved: "in_progress",
|
||||
drafting: "in_progress",
|
||||
qa_review: "in_progress",
|
||||
drafted: "in_progress",
|
||||
exported: "in_progress",
|
||||
reviewed: "in_progress",
|
||||
final: "done",
|
||||
};
|
||||
caseNumber: legalCase.case_number,
|
||||
status: legalCase.status,
|
||||
},
|
||||
);
|
||||
continue;
|
||||
}
|
||||
|
||||
const statusLabels: Record<string, string> = {
|
||||
new: "תיק חדש",
|
||||
uploading: "העלאת מסמכים",
|
||||
processing: "עיבוד מסמכים",
|
||||
documents_ready: "מסמכים מוכנים — הזן תוצאה",
|
||||
outcome_set: "תוצאה הוזנה — נדרש סיעור מוחות",
|
||||
brainstorming: "גיבוש כיוון בתהליך",
|
||||
direction_approved: "כיוון אושר — מוכן לכתיבה",
|
||||
drafting: "כתיבת החלטה בתהליך",
|
||||
qa_review: "בדיקת איכות",
|
||||
drafted: "טיוטה מוכנה — בדוק ושלח לדפנה",
|
||||
exported: "DOCX נוצר — ממתין לדפנה",
|
||||
reviewed: "דפנה הגיהה — העלה גרסה סופית",
|
||||
final: "גרסה סופית — לולאת למידה",
|
||||
};
|
||||
const candidates = byCase.get(legalCase.case_number) ?? [];
|
||||
const { target, reason, writableRoots } =
|
||||
pickSyncTargetIssue(candidates);
|
||||
|
||||
const targetStatus = statusMap[legalCase.status];
|
||||
const label = statusLabels[legalCase.status] || legalCase.status;
|
||||
if (!target) {
|
||||
// אין בליעה שקטה: מדווח למה לא נכתב כלום.
|
||||
ctx.logger.info("sync-case-status: no sync target", {
|
||||
caseNumber: legalCase.case_number,
|
||||
reason,
|
||||
linked: candidates.length,
|
||||
writableRoots,
|
||||
});
|
||||
continue;
|
||||
}
|
||||
|
||||
if (target.status === targetStatus) continue;
|
||||
|
||||
const label =
|
||||
labelFor(statusModel.statuses, legalCase.status) ??
|
||||
legalCase.status;
|
||||
|
||||
if (targetStatus && issue.status !== targetStatus) {
|
||||
await ctx.issues.update(
|
||||
issue.id,
|
||||
target.id,
|
||||
{ status: targetStatus },
|
||||
companyId,
|
||||
target.companyId,
|
||||
);
|
||||
await ctx.issues.createComment(
|
||||
issue.id,
|
||||
target.id,
|
||||
`📋 ${label}`,
|
||||
companyId,
|
||||
target.companyId,
|
||||
);
|
||||
ctx.logger.info("Synced issue status", {
|
||||
issueId: issue.id,
|
||||
issueId: target.id,
|
||||
caseNumber: legalCase.case_number,
|
||||
newStatus: targetStatus,
|
||||
});
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
ctx.logger.info("Case status sync completed", {
|
||||
casesChecked: cases.length,
|
||||
@@ -859,9 +938,8 @@ const plugin = definePlugin({
|
||||
|
||||
ctx.jobs.register("stale-case-reminder", async (_job) => {
|
||||
ctx.logger.info("stale-case-reminder: starting");
|
||||
const config = await ctx.config.get();
|
||||
const apiBase =
|
||||
(config.legalApiBaseUrl as string) ?? "http://localhost:8085";
|
||||
// Scheduled job — no company context; resolveApiBase probes known companies.
|
||||
const apiBase = await resolveApiBase(ctx);
|
||||
|
||||
let resp: Awaited<ReturnType<typeof ctx.http.fetch>>;
|
||||
try {
|
||||
@@ -933,9 +1011,8 @@ const plugin = definePlugin({
|
||||
|
||||
ctx.jobs.register("weekly-feedback-analysis", async (_job) => {
|
||||
ctx.logger.info("weekly-feedback-analysis: starting");
|
||||
const config = await ctx.config.get();
|
||||
const apiBase =
|
||||
(config.legalApiBaseUrl as string) ?? "http://localhost:8085";
|
||||
// Scheduled job — no company context; resolveApiBase probes known companies.
|
||||
const apiBase = await resolveApiBase(ctx);
|
||||
|
||||
const resp = await ctx.http.fetch(
|
||||
`${apiBase}/api/chair-feedback/weekly-summary`,
|
||||
@@ -1129,9 +1206,7 @@ const plugin = definePlugin({
|
||||
if (!issueId) return null;
|
||||
const caseNumber = await resolveCaseNumber(issueId);
|
||||
if (!caseNumber) return null;
|
||||
const config2 = await ctx.config.get();
|
||||
const apiBase =
|
||||
(config2.legalApiBaseUrl as string) ?? "http://localhost:8085";
|
||||
const apiBase = await resolveApiBase(ctx, companyIdOf(params));
|
||||
try {
|
||||
const resp = await ctx.http.fetch(
|
||||
`${apiBase}/api/cases/${encodeURIComponent(caseNumber)}/legal-arguments`,
|
||||
@@ -1168,9 +1243,7 @@ const plugin = definePlugin({
|
||||
if (!issueId) return [];
|
||||
const caseNumber = await resolveCaseNumber(issueId);
|
||||
if (!caseNumber) return [];
|
||||
const config2 = await ctx.config.get();
|
||||
const apiBase =
|
||||
(config2.legalApiBaseUrl as string) ?? "http://localhost:8085";
|
||||
const apiBase = await resolveApiBase(ctx, companyIdOf(params));
|
||||
try {
|
||||
const resp = await ctx.http.fetch(
|
||||
`${apiBase}/api/cases/${encodeURIComponent(caseNumber)}/precedents`,
|
||||
@@ -1206,9 +1279,7 @@ const plugin = definePlugin({
|
||||
if (!issueId) return [];
|
||||
const caseNumber = await resolveCaseNumber(issueId);
|
||||
if (!caseNumber) return [];
|
||||
const config2 = await ctx.config.get();
|
||||
const apiBase =
|
||||
(config2.legalApiBaseUrl as string) ?? "http://localhost:8085";
|
||||
const apiBase = await resolveApiBase(ctx, companyIdOf(params));
|
||||
try {
|
||||
const url = new URL(`${apiBase}/api/missing-precedents`);
|
||||
url.searchParams.set("case_number", caseNumber);
|
||||
|
||||
@@ -12,5 +12,6 @@
|
||||
"jsx": "react-jsx",
|
||||
"lib": ["ES2022", "DOM", "DOM.Iterable"]
|
||||
},
|
||||
"include": ["src"]
|
||||
"include": ["src"],
|
||||
"exclude": ["src/**/*.test.ts"]
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user