feat(plugin): סגירה אוטומטית של issue שטן-מליץ אחרי ריצה מוצלחת — מעיר את ה-CEO (legal-ai #892)
Some checks failed
INV-INT9 issue.status write-ownership / int9-guard (pull_request) Failing after 6s
Some checks failed
INV-INT9 issue.status write-ownership / int9-guard (pull_request) Failing after 6s
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PRePqBSqn3kjwjg9puEJZz
This commit is contained in:
136
src/devil-closer.ts
Normal file
136
src/devil-closer.ts
Normal file
@@ -0,0 +1,136 @@
|
||||
/**
|
||||
* סגירה אוטומטית של issue "שטן-מליץ" אחרי ריצה מוצלחת (legal-ai #892).
|
||||
*
|
||||
* הרקע: סוכן Gemini רץ בלי shell (#872) ולכן אינו יכול לסגור את ה-issue שלו.
|
||||
* Paperclip מעיר את ה-CEO רק על `issue_children_completed` (ילד ב-`done`), ו-issue
|
||||
* שנשאר פתוח עובר ל-`blocked` ("successful run missing disposition") — וה-CEO אינו
|
||||
* מתעורר לעולם (אין לו heartbeat מחזורי). התוצאה בתיק 8165-11-25: המזכר נכתב והתהליך נתקע.
|
||||
*
|
||||
* הלוגיקה כאן טהורה (תלויות מוזרקות) כדי שאפשר לבדוק אותה בלי host.
|
||||
*/
|
||||
|
||||
/** חברה → agent id של שטן-מליץ (Gemini) באותה חברה. */
|
||||
export const DEVIL_AGENT_IDS: Record<string, string> = {
|
||||
"42a7acd0-30c5-4cbd-ac97-7424f65df294":
|
||||
"9c86e06a-5a92-4723-af6d-e8cc6ae1d45b", // CMP
|
||||
"8639e837-4c9d-47fa-a76b-95788d651896":
|
||||
"46cc1228-a232-410b-a36b-71a6928499a2", // CMPA
|
||||
};
|
||||
|
||||
export const DEFAULT_CASES_DIR = "/home/chaim/legal-ai/data/cases";
|
||||
/** מזכר קצר מזה = כנראה ריצה ריקה/חלקית, לא סוגרים. */
|
||||
export const MIN_CRITIQUE_BYTES = 2000;
|
||||
|
||||
const CLOSED = new Set(["done", "cancelled"]);
|
||||
|
||||
export interface DevilIssueLike {
|
||||
id: string;
|
||||
title: string;
|
||||
status: string;
|
||||
assigneeAgentId?: string | null;
|
||||
createdAt?: string | Date | null;
|
||||
}
|
||||
|
||||
export interface DevilRunPayload {
|
||||
agentId?: string;
|
||||
issueId?: string | null;
|
||||
status?: string;
|
||||
}
|
||||
|
||||
export interface CloseDeps {
|
||||
getIssue(issueId: string, companyId: string): Promise<DevilIssueLike | null>;
|
||||
/** גודל + זמן-שינוי של הקובץ, או null אם אינו קיים. זורק רק על כשל-גישה. */
|
||||
statCritique(
|
||||
caseNumber: string,
|
||||
): Promise<{ size: number; mtimeMs: number } | null>;
|
||||
closeIssue(issueId: string, companyId: string): Promise<void>;
|
||||
log(
|
||||
level: "info" | "warn",
|
||||
msg: string,
|
||||
meta?: Record<string, unknown>,
|
||||
): void;
|
||||
}
|
||||
|
||||
export function caseNumberFromTitle(title: string): string | null {
|
||||
const m = title.match(/\[ערר\s+([^\]\s]+)\]/);
|
||||
return m ? m[1] : null;
|
||||
}
|
||||
|
||||
export function isDevilTitle(title: string): boolean {
|
||||
return title.includes("שטן-מליץ");
|
||||
}
|
||||
|
||||
export type CloseOutcome =
|
||||
| "closed"
|
||||
| "not_devil_run"
|
||||
| "no_issue"
|
||||
| "not_devil_issue"
|
||||
| "already_closed"
|
||||
| "no_case_number"
|
||||
| "no_deliverable"
|
||||
| "stat_failed";
|
||||
|
||||
/**
|
||||
* מופעל על `agent.run.finished` (status=succeeded בלבד). סוגר את ה-issue רק אם:
|
||||
* הריצה של שטן-מליץ של אותה חברה, ה-issue שלו פתוח, וקיים `critique-gemini.md` עדכני ולא ריק.
|
||||
*/
|
||||
export async function closeDevilIssueIfDone(
|
||||
companyId: string | undefined,
|
||||
payload: DevilRunPayload | null,
|
||||
deps: CloseDeps,
|
||||
): Promise<CloseOutcome> {
|
||||
if (!companyId || !payload) return "not_devil_run";
|
||||
const devilId = DEVIL_AGENT_IDS[companyId];
|
||||
if (!devilId || payload.agentId !== devilId) return "not_devil_run";
|
||||
if (payload.status && payload.status !== "succeeded") return "not_devil_run";
|
||||
if (!payload.issueId) return "no_issue";
|
||||
|
||||
const issue = await deps.getIssue(payload.issueId, companyId);
|
||||
if (!issue) return "no_issue";
|
||||
if (issue.assigneeAgentId !== devilId || !isDevilTitle(issue.title)) {
|
||||
return "not_devil_issue";
|
||||
}
|
||||
if (CLOSED.has(issue.status)) return "already_closed";
|
||||
|
||||
const caseNumber = caseNumberFromTitle(issue.title);
|
||||
if (!caseNumber) return "no_case_number";
|
||||
|
||||
let st: { size: number; mtimeMs: number } | null;
|
||||
try {
|
||||
st = await deps.statCritique(caseNumber);
|
||||
} catch {
|
||||
deps.log(
|
||||
"warn",
|
||||
"devil auto-close: critique stat failed; leaving issue open",
|
||||
{
|
||||
issueId: issue.id,
|
||||
caseNumber,
|
||||
},
|
||||
);
|
||||
return "stat_failed";
|
||||
}
|
||||
const created = issue.createdAt ? new Date(issue.createdAt).getTime() : 0;
|
||||
if (!st || st.size < MIN_CRITIQUE_BYTES || st.mtimeMs < created) {
|
||||
deps.log(
|
||||
"warn",
|
||||
"devil auto-close: no fresh critique-gemini.md; leaving issue open",
|
||||
{
|
||||
issueId: issue.id,
|
||||
caseNumber,
|
||||
size: st?.size ?? null,
|
||||
},
|
||||
);
|
||||
return "no_deliverable";
|
||||
}
|
||||
|
||||
await deps.closeIssue(issue.id, companyId);
|
||||
deps.log(
|
||||
"info",
|
||||
"devil auto-close: issue closed (CEO is woken by issue_children_completed)",
|
||||
{
|
||||
issueId: issue.id,
|
||||
caseNumber,
|
||||
},
|
||||
);
|
||||
return "closed";
|
||||
}
|
||||
Reference in New Issue
Block a user