Chaim
69b34f1c3f
Live drain surfaced three issues:
1. Tier-0 needed `h2` (httpx http2) — added to the court-fetch extra.
2. Supreme cases that carry a נט-format number (e.g. בר"מ 72182-06-25) were
routed to the unvalidated Tier-0 and failed, even though נט המשפט serves
Supreme cases too. classify() now parses the file-month-year triple for
Supreme prefixes; the orchestrator routes by triple-availability:
נט-format present → Tier-1 (validated, all courts)
serial-only Supreme (עע"מ 5886/24) → Tier-0
neither → clear "no public route" failure
Validated live: בר"מ 72182-06-25 fetched via Tier-1 (5-page PDF).
3. A non-`RuntimeError` fetch exception (the h2 import error) left jobs stuck
in 'running'. The fetch block now catches any Exception → _record_failure
(INV-CF2/CF3), so a job always reaches a terminal state.
+ test_supreme_with_net_format_triple. Suite 11/11.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
92 lines
3.2 KiB
Python
92 lines
3.2 KiB
Python
"""Unit tests for the X13 court-citation classifier."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from legal_mcp.services.court_citation import classify, normalize_case_number
|
|
|
|
|
|
def test_admin_filed_format_the_example():
|
|
"""The plan's example: עת"מ 46111-12-22 → admin, parsed into (46111,12,22)."""
|
|
c = classify('עת"מ 46111-12-22 יכין-אפק בע"מ נ\' הוועדה המחוזית')
|
|
assert c.tier == "admin"
|
|
assert c.court_prefix in ('עת"מ', "עת״מ")
|
|
assert c.case_number_raw == "46111-12-22"
|
|
assert c.case_number_norm == "46111-12-22"
|
|
assert (c.file_number, c.month, c.year) == ("46111", "12", "22")
|
|
assert c.fetchable is True
|
|
|
|
|
|
def test_bare_filed_number_defaults_admin():
|
|
c = classify("46111-12-22")
|
|
assert c.tier == "admin"
|
|
assert (c.file_number, c.month, c.year) == ("46111", "12", "22")
|
|
|
|
|
|
def test_supreme_prefixes():
|
|
for cit, pref in [
|
|
('עע"מ 1234/22', "supreme"),
|
|
('בג"ץ 5678/21', "supreme"),
|
|
('ע"א 999/20', "supreme"),
|
|
('רע"א 4/19', "supreme"),
|
|
('בר"מ 8126/24', "supreme"),
|
|
]:
|
|
c = classify(cit)
|
|
assert c.tier == pref, f"{cit} -> {c.tier}"
|
|
assert c.fetchable is True
|
|
|
|
|
|
def test_appeals_committee_is_skip():
|
|
"""ערר / בל"מ must never be auto-fetched (needs Nevo) — INV-CF6."""
|
|
for cit in ['ערר 1110/20', 'בל"מ 8048/24', "ערר 1015-01-24 ירושלים שקופה"]:
|
|
c = classify(cit)
|
|
assert c.tier == "skip", f"{cit} -> {c.tier}"
|
|
assert c.fetchable is False
|
|
|
|
|
|
def test_skip_wins_over_court_match():
|
|
"""An 'ערר' citation that also contains court-like digits stays skip."""
|
|
c = classify("ראה החלטתי בערר 1041/24 ובהמשך")
|
|
assert c.tier == "skip"
|
|
|
|
|
|
def test_admin_amn_prefix():
|
|
c = classify('עמ"נ 12345-06-23')
|
|
assert c.tier == "admin"
|
|
assert (c.file_number, c.month, c.year) == ("12345", "06", "23")
|
|
|
|
|
|
def test_two_group_serial_has_no_filed_triple():
|
|
"""Supreme serial 1234/22 normalizes but yields no (file,month,year)."""
|
|
c = classify('עע"מ 1234/22')
|
|
assert c.case_number_norm == "1234-22"
|
|
assert c.file_number is None
|
|
|
|
|
|
def test_implausible_month_not_parsed_as_filed():
|
|
# 1234-22-05 has month=22 → not a valid filed triple.
|
|
assert classify("1234-22-05").tier in ("unknown", "admin")
|
|
c = classify("1234-22-05")
|
|
if c.tier == "admin":
|
|
assert c.month is None
|
|
|
|
|
|
def test_empty_and_garbage():
|
|
assert classify("").tier == "unknown"
|
|
assert classify("שלום עולם בלי ציטוט").tier == "unknown"
|
|
|
|
|
|
def test_normalize_case_number():
|
|
assert normalize_case_number('עת"מ 46111/12/22') == "46111-12-22"
|
|
assert normalize_case_number("1110/20") == "1110-20"
|
|
|
|
|
|
def test_supreme_with_net_format_triple():
|
|
"""A Supreme prefix carrying a נט-format number exposes the triple so the
|
|
orchestrator can route it to Tier-1 (נט המשפט serves Supreme too)."""
|
|
c = classify('בר"מ 72182-06-25 הימנותא נ\' הוועדה המקומית')
|
|
assert c.tier == "supreme"
|
|
assert (c.file_number, c.month, c.year) == ("72182", "06", "25")
|
|
# serial-format Supreme has no triple → stays Tier-0-only
|
|
s = classify('עע"מ 5886/24')
|
|
assert s.tier == "supreme" and s.file_number is None
|