ezer-mishpati/legal-ai
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Forbid slashes in case numbers

Browse Source 
FastAPI path routing can't capture a slash inside a {case_number}
segment — %2F gets decoded before route matching, so any case created
with "1000/0426" becomes permanently unreachable at
GET /api/cases/{case_number}/details. Enforce the hyphen convention
used by existing prod cases (1033-25, 1130-25) at the zod layer so
the wizard rejects the bad shape before submit.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Chaim
2026-04-11 16:41:40 +00:00
parent 75ea6825b2
commit d8a537e7aa
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
web-ui/src/lib/schemas/case.ts
View File

@@ -11,9 +11,13 @@
import { z } from "zod"; import { z } from "zod";
/* Appeal numbers follow the 1xxx / 8xxx / 9xxx convention from CLAUDE.md — /* Appeal numbers follow the 1xxx / 8xxx / 9xxx convention from CLAUDE.md.
* permissive regex that still catches obvious typos. */ * Slashes are deliberately forbidden: FastAPI path routing can't capture
const caseNumberRe = /^[1-9]\d{3,}(?:[-/][\w\u0590-\u05FF]+)*$/; * a `/` inside a case-number segment even when URL-encoded as %2F, so
* any case created with a slash becomes unreachable at
* GET /api/cases/{case_number}/details. Existing prod cases use hyphens
* (e.g. "1033-25", "1130-25") which is the enforced convention here. */
const caseNumberRe = /^[1-9]\d{3,}(?:-[\w\u0590-\u05FF]+)*$/;
const hebrewPartyRe = /[\u0590-\u05FFA-Za-z]/; const hebrewPartyRe = /[\u0590-\u05FFA-Za-z]/;
@@ -37,7 +41,7 @@ export const caseCreateSchema = z.object({
.string() .string()
.trim() .trim()
.min(1, "שדה חובה") .min(1, "שדה חובה")
.regex(caseNumberRe, "מספר תיק לא תקין (למשל 1234 או 8001/2026)"), .regex(caseNumberRe, "מספר תיק לא תקין — השתמש במקף, לא בקו נטוי (למשל 1033-25)"),
title: z.string().trim().min(3, "כותרת קצרה מדי").max(200, "כותרת ארוכה מדי"), title: z.string().trim().min(3, "כותרת קצרה מדי").max(200, "כותרת ארוכה מדי"),
appellants: z appellants: z
.array(z.string().trim().min(1).refine((v) => hebrewPartyRe.test(v), "שם לא תקין")) .array(z.string().trim().min(1).refine((v) => hebrewPartyRe.test(v), "שם לא תקין"))