From 987da57da4196fa30121a1b78e0017d0234b48e1 Mon Sep 17 00:00:00 2001
From: Chaim <chaim@marcus-law.co.il>
Date: Sun, 28 Jun 2026 22:59:31 +0000
Subject: [PATCH] feat(ui): synthesis/superseded badges + merge provenance in
 lessons-tab (#162)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

עוצב ואושר דרך שער-העיצוב (Claude Design 12c-training-lessons.html).
- lessons-tab: SOURCE_BADGE['synthesis']="סינתזה" (navy מלא) · REVIEW_BADGE['superseded']="מוזג"
  (אפור-מעומעם, לא נדחה); שורות superseded מעומעמות (opacity).
- provenance: לקח-על מציג "⤷ מוזג מ-N לקחים · דחייה תשחזר אותם".
- backend: list_decision_lessons + _lesson_to_json מחזירים synthesized_from; training.ts
  DecisionLesson — 'synthesis'/'superseded' ל-unions + synthesized_from?: string[].

הבאדג'ים היו מוגנים-fallback קודם (ללא קריסה) — כעת מתויגים נכון. closes #162.

בדיקות: py_compile ✓ · leak-guard ✓ · tsc --noEmit ✓.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 mcp-server/src/legal_mcp/services/db.py        |  2 +-
 web-ui/src/components/training/lessons-tab.tsx | 16 +++++++++++++++-
 web-ui/src/lib/api/training.ts                 | 10 ++++++++--
 web/app.py                                     |  3 +++
 4 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/mcp-server/src/legal_mcp/services/db.py b/mcp-server/src/legal_mcp/services/db.py
index e845f81..3d4c3bc 100644
--- a/mcp-server/src/legal_mcp/services/db.py
+++ b/mcp-server/src/legal_mcp/services/db.py
@@ -2655,7 +2655,7 @@ async def list_decision_lessons(corpus_id: UUID) -> list[dict]:
         #  review_status is the single writer gate).
         rows = await conn.fetch(
             "SELECT id, style_corpus_id, lesson_text, category, source, "
-            "       review_status, created_by, created_at, updated_at "
+            "       review_status, created_by, created_at, updated_at, synthesized_from "
             "FROM decision_lessons WHERE style_corpus_id = $1 "
             "ORDER BY created_at DESC",
             corpus_id,
diff --git a/web-ui/src/components/training/lessons-tab.tsx b/web-ui/src/components/training/lessons-tab.tsx
index fe48bb1..10d3c90 100644
--- a/web-ui/src/components/training/lessons-tab.tsx
+++ b/web-ui/src/components/training/lessons-tab.tsx
@@ -54,6 +54,9 @@ const SOURCE_BADGE: Record<string, { label: string; cls: string }> = {
   curator: { label: "הרמס (סקירה)", cls: "bg-info-bg text-info" },
   style_analyzer: { label: "מנתח-סגנון", cls: "bg-success-bg text-success" },
   "panel:deepseek+gemini": { label: "פאנל: דיפסיק+גמיני", cls: "bg-gold-wash text-gold-deep" },
+  // #158/INV-LRN8 — a super-lesson merging overlapping lessons; navy-filled so it
+  // reads as the consolidated/elevated one.
+  synthesis: { label: "סינתזה", cls: "bg-navy text-parchment" },
 };
 
 const SOURCE_BADGE_FALLBACK = { label: "פאנל", cls: "bg-rule-soft text-ink-soft" };
@@ -63,6 +66,9 @@ const REVIEW_BADGE: Record<string, { label: string; cls: string }> = {
   proposed: { label: "ממתין לאישור", cls: "bg-gold-wash text-gold-deep border-gold/40" },
   approved: { label: "מאושר · זורם לכותב", cls: "bg-success-bg text-success border-success/40" },
   rejected: { label: "נדחה", cls: "bg-rule-soft text-ink-muted line-through" },
+  // #158/INV-LRN8 — merged into a synthesis super-lesson; kept as provenance, no
+  // longer fed to the writer. Muted (not struck — it wasn't rejected).
+  superseded: { label: "מוזג", cls: "bg-rule-soft text-ink-muted" },
 };
 
 export function LessonsTab({ corpusId }: { corpusId: string }) {
@@ -201,8 +207,10 @@ function LessonItem({
     }
   };
 
+  const mergedCount = lesson.source === "synthesis" ? (lesson.synthesized_from?.length ?? 0) : 0;
+
   return (
-    <Card className="bg-surface border-rule">
+    <Card className={`bg-surface border-rule ${lesson.review_status === "superseded" ? "opacity-70" : ""}`}>
       <CardContent className="px-4 py-3 space-y-2">
         <div className="flex items-center gap-2 text-[0.72rem]">
           <Badge variant="outline"
@@ -220,6 +228,12 @@ function LessonItem({
           </span>
         </div>
 
+        {mergedCount > 0 && (
+          <div className="text-[0.72rem] text-ink-muted">
+            ⤷ מוזג מ-<b className="text-navy font-semibold">{mergedCount} לקחים</b> · דחייה תשחזר אותם
+          </div>
+        )}
+
         {editing ? (
           <>
             <Textarea value={text} onChange={(e) => setText(e.target.value)}
diff --git a/web-ui/src/lib/api/training.ts b/web-ui/src/lib/api/training.ts
index 09eebc3..92601c2 100644
--- a/web-ui/src/lib/api/training.ts
+++ b/web-ui/src/lib/api/training.ts
@@ -504,14 +504,20 @@ export type DecisionLesson = {
   category: "style" | "structure" | "lexicon" | "tabular" | "general";
   // "panel:deepseek+gemini" — the two-judge style panel; (string) keeps it open
   // to future panel sources without a type break.
-  source: "manual" | "curator" | "chair" | "style_analyzer" | (string & {});
+  // "synthesis" — a super-lesson merging overlapping lessons (#158/INV-LRN8);
+  // "panel:deepseek+gemini" — the two-judge style panel; (string) keeps it open.
+  source: "manual" | "curator" | "chair" | "style_analyzer" | "synthesis" | (string & {});
   // review gate (INV-LRN1/G10): only "approved" lessons flow to the writer.
   // Panel-written lessons start as "proposed" and wait for the chair here.
+  // "superseded" — a source lesson merged into a synthesis (#158); kept as
+  // provenance, no longer fed to the writer.
   // (applied_to_skill removed — LRN-1/INV-IA3: review_status is the single gate.)
-  review_status: "proposed" | "approved" | "rejected";
+  review_status: "proposed" | "approved" | "rejected" | "superseded";
   created_by: string;
   created_at: string;
   updated_at: string;
+  // #158/INV-LRN8: ids of the source lessons a 'synthesis' row merged (provenance).
+  synthesized_from?: string[];
 };
 
 export type LessonReviewStatus = DecisionLesson["review_status"];
diff --git a/web/app.py b/web/app.py
index c8cfedd..6fde202 100644
--- a/web/app.py
+++ b/web/app.py
@@ -1544,6 +1544,9 @@ def _lesson_to_json(row: dict) -> dict:
         "created_by": row.get("created_by", ""),
         "created_at": row["created_at"].isoformat() if row.get("created_at") else "",
         "updated_at": row["updated_at"].isoformat() if row.get("updated_at") else "",
+        # #158/INV-LRN8: source lessons a 'synthesis' super-lesson merged (provenance);
+        # empty for non-synthesis rows. Lets the UI show "מוזג מ-N לקחים".
+        "synthesized_from": [str(x) for x in (row.get("synthesized_from") or [])],
     }