From 3c431403f651c2cd7e6ccdfb52b35a6ff0c2c380 Mon Sep 17 00:00:00 2001 From: Chaim Date: Sat, 30 May 2026 19:26:53 +0000 Subject: [PATCH] refactor(ingest): drop obsolete queue_halachot flag + dead imports (FU-1 review) pipeline always queues both extraction kinds (INV-ING3); remove the now-meaningless queue_halachot param from ingest_internal_decision and migrate_from_style_corpus. Also trim chunker/extractor/rerank from the precedent_library module-top import (chunking/extraction moved to ingest.py). Co-Authored-By: Claude Sonnet 4.6 --- mcp-server/src/legal_mcp/services/internal_decisions.py | 4 +--- mcp-server/src/legal_mcp/services/precedent_library.py | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/mcp-server/src/legal_mcp/services/internal_decisions.py b/mcp-server/src/legal_mcp/services/internal_decisions.py index 5a0dd4e..898de30 100644 --- a/mcp-server/src/legal_mcp/services/internal_decisions.py +++ b/mcp-server/src/legal_mcp/services/internal_decisions.py @@ -111,7 +111,6 @@ async def ingest_internal_decision( file_path: str | Path | None = None, text: str | None = None, document_id: UUID | None = None, - queue_halachot: bool = True, # retained for signature compat; pipeline always queues proceeding_type: str = "", ) -> dict: """Ingest one appeals-committee decision. Thin wrapper over the canonical pipeline.""" @@ -130,7 +129,7 @@ async def ingest_internal_decision( "chunks": out["chunks"], "halachot_pending": True} -async def migrate_from_style_corpus(dry_run: bool = False, queue_halachot: bool = True) -> dict: +async def migrate_from_style_corpus(dry_run: bool = False) -> dict: """Re-index all style_corpus entries as searchable internal committee decisions. Does NOT delete style_corpus rows — they remain for style analysis. @@ -188,7 +187,6 @@ async def migrate_from_style_corpus(dry_run: bool = False, queue_halachot: bool appeal_subtype=subtype, subject_tags=subject_tags, text=row["full_text"], - queue_halachot=queue_halachot, ) results["ingested"] += 1 logger.info("Migrated style_corpus entry: %s", case_number) diff --git a/mcp-server/src/legal_mcp/services/precedent_library.py b/mcp-server/src/legal_mcp/services/precedent_library.py index 303a1cd..34618bb 100644 --- a/mcp-server/src/legal_mcp/services/precedent_library.py +++ b/mcp-server/src/legal_mcp/services/precedent_library.py @@ -20,7 +20,7 @@ from typing import Awaitable, Callable from uuid import UUID from legal_mcp import config -from legal_mcp.services import chunker, db, embeddings, extractor, hybrid_search, ingest, rerank # noqa: F401 +from legal_mcp.services import db, embeddings, hybrid_search, ingest # noqa: F401 # Note: halacha_extractor and precedent_metadata_extractor are NOT imported # at module load. They are imported lazily inside the dedicated re-extract